[Build Process] Template with C linkage

[forflo]

Hi Everyone,

in src/roseExtensions/roseHPCTollkit/include/rosehpct/xml/xml.hh there is an include surrounded with C linkage braces.

Using g++ with version 7.4.1 and libxml2 2.9.9-2 this breaks the build. Removing the linkage braces fixes the whole build on my machine (Arch linux; rolling release; just did system upgrade).

• My libxml2 version: 2.9.9-2
• The libxml2 version as installed on Ubuntu 18.04: 2.9.4+dfsg1-6.1ubuntu1.2

Both libxml2 versions seem to have proper conditional compilation based on whether one compiles with a C++ compiler or C compiler? Hence, any good reason for this?

Additional Information

In case you find some quality time:

In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/7.4.1/include/c++/memory:66:0,
                 from /usr/include/unicode/localpointer.h:45,
                 from /usr/include/unicode/uenum.h:23,
                 from /usr/include/unicode/ucnv.h:53,
                 from /usr/include/libxml2/libxml/encoding.h:31,
                 from /usr/include/libxml2/libxml/parser.h:810,
                 from ../../../../../../ROSE/src/roseExtensions/roseHPCToolkit/include/rosehpct/xml/xml.hh:37,
                 from ../../../../../../ROSE/src/roseExtensions/roseHPCToolkit/src/xml/elem.cc:10:
/usr/lib/gcc/x86_64-pc-linux-gnu/7.4.1/include/c++/bits/stl_tempbuf.h:83:3: Error: template with C linkage

REPRODUCTION

I whipped up a package for reproduction for you. Please refer to the README.md in this repository for further instructions.

Note, that the build process of the VM described in Vagrantfile may take up to 2 hours depending on your PC. I can get the VM to you over SCP if you prefer, but it is quite big and it might easily take the same amount time to transfer it to the west coast 😄

Thanks & Best regards

[forflo]

This is actually a duplicate of #48. However, since nobody bothered to re-open that issue, ... I did that for you ;-)

[forflo]

Hi,

I just noticed that my reproduction package did not built again. This is fixed now!

Best regards

[peihunglin]

The suggested fix is merged into the develop branch.