Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Foxy #202

Closed
clalancette opened this issue Apr 30, 2020 · 11 comments
Closed

Release for Foxy #202

clalancette opened this issue Apr 30, 2020 · 11 comments

Comments

@clalancette
Copy link
Contributor

Hello @ros2/security_working_group ! This is your friendly ROS 2 Foxy release team. We are currently going through the process of blooming all of the packages in ros_core, and the last one to come up is sros2. We believe all of the dependencies for sros2 are now available, so would you mind doing a release into Foxy? Let us know if you need assistance or don't have time to do it. Thanks.

@mikaelarguedas
Copy link
Member

Hi! Similar to the discussion that happened a couple days ago in the matrix chat, the release is currently blocked by the lack of any passing security test on Foxy.
More details are available on this testing matrix: #180 (comment)

We would love to get some assistance from OR to move those CI issues forward as this is mostly out of our reach. /cc @jacobperron

@clalancette
Copy link
Contributor Author

Hi! Similar to the discussion that happened a couple days ago in the matrix chat, the release is currently blocked by the lack of any passing security test on Foxy.
More details are available on this testing matrix: #180 (comment)

Ah, sorry, I wasn't aware of the matrix chat when I opened this.

We would love to get some assistance from OR to move those CI issues forward as this is mostly out of our reach. /cc @jacobperron

All right, I'll get together with @ivanpauno and @jacobperron and see what we can do to help this forward.

@mikaelarguedas
Copy link
Member

sounds great!
Feel free to ping me if you need more details of what has been tried and what is currently unclear to us or not working

@kyrofa
Copy link
Member

kyrofa commented May 6, 2020

Sounds like we're also waiting on ros2cli for this.

@jacobperron
Copy link
Member

Sounds like we're also waiting on ros2cli for this.

How so? ros2cli is released into Foxy.

@mikaelarguedas
Copy link
Member

How so? ros2cli is released into Foxy.

This was a fluke of the blocked release page https://repo.ros2.org/status_page/blocked_releases_foxy.html?q=id%3D%22variants%22&s=6&r=1 ros2cli is still listed as a blocking repo but it's actually released

@mikaelarguedas
Copy link
Member

actually we do rely on unreleased ros2cli feature ros2/ros2cli#501

It shouldn't prevent the deb from building though but this means that the policy generation won't work until the next ros2cli version. @jacobperron should I open a ticket on ros2cli or will it be rereleased shortly anyway ?

@jacobperron
Copy link
Member

jacobperron commented May 6, 2020

I can make a patch release for ros2cli shortly so that it's there for testing.

@mikaelarguedas
Copy link
Member

ros/rosdistro#24745 🚀

@jacobperron
Copy link
Member

ros2cli patch release: ros/rosdistro#24746

@jacobperron
Copy link
Member

jacobperron commented May 6, 2020

I'm going to close this since we have a release for Foxy. But, I'd still like to make a concerted effort to make sure tests are enabled (and passing) for security on all platforms before the final Foxy release (release candidate on May 27th).
We have #180 for tracking.

@mikaelarguedas Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants