Cleanup github actions. #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add in the sphinx-multiversion pip dependency. It isn't required on the master branch, but it doesn't hurt anything and is needed on the rolling, foxy, and dashing branches. 2. Github actions fail immediately if the command returns non-zero. Since we were capturing the output, this was effectively hiding the error from us. We now just check things sequentially. This is better in that it is simpler, but worse in that you don't get all of the errors at once. I still like the simpler approach. 3. Get rid of the exclusions for the action tutorials, as it doesn't seem to be needed anymore. Signed-off-by: Chris Lalancette <[email protected]>
maryaB-osr
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in the sphinx-multiversion pip dependency. It isn't
required on the master branch, but it doesn't hurt anything
and is needed on the rolling, foxy, and dashing branches.
Github actions fail immediately if the command returns
non-zero. Since we were capturing the output, this was
effectively hiding the error from us. We now just check
things sequentially. This is better in that it is simpler,
but worse in that you don't get all of the errors at once.
I still like the simpler approach.
Get rid of the exclusions for the action tutorials, as
it doesn't seem to be needed anymore.
Signed-off-by: Chris Lalancette [email protected]
Note that I am targeting master with this PR on purpose. Once we are happy with this on master, I'll backport by hand to the rolling, dashing, and foxy branches.