-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dashing 'interface show' syntax back to tutorials #685
Conversation
Signed-off-by: maryaB-osr <[email protected]>
Signed-off-by: maryaB-osr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good. One thing I'd prefer is if we can mark the "Eloquent or newer" tab as the default one selected. Do you know how to do that?
Signed-off-by: maryaB-osr <[email protected]>
@clalancette it just depends on what order they're in, first is the default |
Ah, that's unfortunate. What have we done elsewhere? I think it is important that we be consistent across the tutorials. |
I think I'll open another PR to make these consistent. Not only the order (some tutorials have older-first, some have newer-first) but also the wording (we have "Eloquent and newer", "Eloquent or newer", "Eloquent+", "Eloquent/Foxy", etc). I guess I can branch off of this branch to do that (unless you think this should be merged first) |
I think it makes sense to do it all in here, since we are dealing with the tabs in this PR. |
Signed-off-by: maryaB-osr <[email protected]>
They're all left-to-right foxy-to-dashing now, and just use "/" if it applies to more than one distro. So if it's something common to Foxy and Eloquent, it'll be
And if it's common to Eloquent and Dashing but Foxy is different, then:
|
I probably should have thought of this earlier, but this is going to cause us to have to revisit all of these tabs for G-Turtle as well. I think I'd prefer something more like:
or:
That is, we assume that things will remain the same going forwards, but we call out the differences to the still supported versions. @maryaB-osr does that make sense to you? |
Signed-off-by: maryaB-osr <[email protected]>
went with your suggestion @clalancette. i also removed a big section "crystal only" section, i think that's safe right? |
Yeah, we can remove things referring to Crystal and older, they are no longer supported. |
People still use Dashing
Didn't change the Actions tutorials, will do in the open PR for Actions: #594
Signed-off-by: maryaB-osr [email protected]