-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates for upcoming Eloquent release #310
Conversation
Great, we've been discussing putting this up now to be pointed to by the "latest" page, what do you think about that? I was putting together the file structure here, obviously without the content (and I'll just scrap that PR now). The idea is that references to the "latest" developments, if anyone's interested in installing them, will point to the upcoming release. For now that's Eloquent. All that would mean is adding a note to "The next (or upcoming) release is under development. You can install it here" And link to That is, if you think it's a good idea to let people install eloquent while it's under development? |
I think prior to at least the alpha, the installation instructions are going to be largely for collaborators to make updates about dependencies and Eloquent-specific instructions. We won't have a first round of packages out until after that date. I would suggest that we maybe delay adding the concept of |
The This should be merged without squashing at the end (to keep the separate commits for duplicating and changing the Eloquent pages). Before that please squash into a minimal number of commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Before Debian packages are available the instructions are used for from-source builds as well as can be used to obtain the nightly archives from Jenkins.
The concept of "latest" always exists. It is the state on the default branches which will become the upcoming release. |
The instructions for binaries are already linked on the Eloquent installation types page, so if we have latest point to it now that part would have to be changed... |
Yeah, I diffed between Crystal and Dashing and there weren't any changes there. Would you propose moving it up a directory? |
Sure, if it is not distro-specific there is no point in duplicating it. |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
893519a
to
1a5d1e6
Compare
I reworked this into a minimal number of commits, and consolidated the maintaining a source checkout to only one page. |
@@ -1,3 +1,4 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the file while also moving it. In this case the extra empty line can just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, sorry I missed that.
Signed-off-by: Michael Carroll <[email protected]>
1a5d1e6
to
e8e7c3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to not-squash merge
The Eloquent release schedule attempts to keep the spacing of the Dashing release, with some slight adjustments for ROSCon. I generally assumed that internal and external contributors will be distracted by travel and the conference, so avoided putting any deadlines in that week.