Consolidate common Connext installation pages #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
hidmic
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
LGTM and I agree with:
...we could add a "Connext" directory that is sibling to "Crystal", "Dashing", etc. where we maintain documentation for different versions of Connext.
Maybe it's for a better directory structure: Installation/Distros/, Installation/Vendors/, etc.?
delete-merged-branch
bot
deleted the
jacob/consolidate_connext_instructions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation instructions were identical for all ROS distributions.
If the instructions change for Eloquent (or future distributions) we could add a "Connext" directory that is sibling to "Crystal", "Dashing", etc. where we maintain documentation for different versions of Connext.
Open to ideas.
Follow-up from #285