Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ros2 param load documentation #1101

Merged
merged 2 commits into from
Feb 13, 2021
Merged

Add ros2 param load documentation #1101

merged 2 commits into from
Feb 13, 2021

Conversation

v-lopez
Copy link

@v-lopez v-lopez commented Feb 12, 2021

No description provided.

@v-lopez
Copy link
Author

v-lopez commented Feb 12, 2021

@audrow Added the documentation as requested, please take a look.

audrow
audrow approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this.

@audrow
Copy link
Member

audrow commented Feb 12, 2021

By the way, this should be merged in after ros2/ros2cli#590.

@audrow audrow self-assigned this Feb 13, 2021
@audrow audrow merged commit c8df1cb into ros2:master Feb 13, 2021
@clalancette clalancette mentioned this pull request Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-lopez @audrow