Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rosbag2 #695

Merged
merged 2 commits into from
May 8, 2019
Merged

Adding rosbag2 #695

merged 2 commits into from
May 8, 2019

Conversation

Karsten1987
Copy link
Contributor

@Karsten1987 Karsten1987 commented Apr 27, 2019 •
edited
Loading

connected to ros2/rosbag2#111

Adding the rosbag2 to the official ros2 repos file.
Current CI running here:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987 Karsten1987 self-assigned this Apr 27, 2019
@Karsten1987 Karsten1987 added the in progress Actively being worked on (Kanban column) label Apr 27, 2019
@Karsten1987 Karsten1987 changed the title Update ros2.repos Adding rosbag2 May 3, 2019
@Karsten1987 Karsten1987 added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 7, 2019
@Karsten1987
Copy link
Contributor Author

with the latest build passing on master, I am putting this in review.
For CI, refer to:
ros2/rosbag2#111 (comment)

jacobperron
jacobperron approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobperron jacobperron merged commit 611c895 into master May 8, 2019
@jacobperron jacobperron deleted the add-rosbag2-repos branch May 8, 2019 00:31
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@Karsten1987 Karsten1987

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karsten1987 @jacobperron