Print out message mapping for fields_2_to_1 rule #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dharini Dutia <[email protected]>
gbiggs
approved these changes
Jun 8, 2022
|
Do you think this can be unit tested? |
I'm not well versed with unit tests, but we'll need to pass the custom messages and mapping rules to validate. Adding GTest would suitable I guess? |
|
CI_Packaging_Linux |
clalancette
requested changes
Jun 16, 2022
Signed-off-by: Dharini Dutia <[email protected]>
clalancette
approved these changes
Jun 27, 2022
|
Thanks a lot, Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #353, mapping rules from ros2 fields to ros1 fields aren't being printed out.
Apparently, the mapping dictionary structure wasn't being populated nor the
fields_2_to_1tag was being checked in the string pairs data.