Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple_topic_monitor to rosdistro #40779

Merged

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Apr 23, 2024

Please add the following dependency to the rosdep database.

Package name:

multiple_topic_monitor

Package Upstream Source:

https://github.com/yukkysaito/multiple_topic_monitor

Purpose of using this:

This is a ROS 2 package for monitoring the frequency and delay of multiple topics.

Distro packaging links: https://github.com/yukkysaito/multiple_topic_monitor/blob/humble/README.md

Background : ros2-gbp/ros2-gbp-github-org#502 (comment)

Links to Distribution Packages

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Apr 23, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New package review checklist

  • At least one of the following must be present
    • Top level license file:
    • Per package license files:
  • License is OSI-approved:
  • License correctly listed in package.xmls
  • Public source repo: https://github.com/yukkysaito/multiple_topic_monitor.git
  • Source repository contains ROS packages
  • Each package meets REP-144 naming conventions - This one is a little hard to determine for sure, as the name is pretty generic. However, it does implement generic functionality, so I think that is OK.

The checklist above is good. However, looking at the package I notice that the description and license in the setup.py are still TODO: https://github.com/yukkysaito/multiple_topic_monitor/blob/60f9affe91514f61f7ee26524c896b6af87903e3/setup.py#L18-L19 .

Once we fix that, I think this will be OK to get in.

@yukkysaito
Copy link
Contributor Author

The checklist above is good. However, looking at the package I notice that the description and license in the setup.py are still TODO: https://github.com/yukkysaito/multiple_topic_monitor/blob/60f9affe91514f61f7ee26524c896b6af87903e3/setup.py#L18-L19 .

@clalancette
Thank you for your review.
I updated the the description and license in the setup.py

@clalancette clalancette merged commit b9f9553 into ros:master Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants