Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename gc_spl to game_controller_spl in humble #40709

Merged
merged 1 commit into from
Apr 22, 2024
Merged

rename gc_spl to game_controller_spl in humble #40709

merged 1 commit into from
Apr 22, 2024

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Apr 20, 2024 •
edited
Loading

As requested in #40578, splitting up the changes into PR per distro.

Repository was renamed recently from gc_spl to game_controller_spl. Instead of updating the name just for rolling's distribution.yaml, for consistency, I updated the names in humble and iron's distribution files too. I'm hoping there are no issues with this manual change.

Related issue in ros2-gbp

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Apr 20, 2024
@ijnek ijnek mentioned this pull request Apr 20, 2024
Closed
clalancette
clalancette approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the old and the new repository redirect to the same place, so this is the same codebase.

@clalancette clalancette merged commit 5a9f468 into ros:master Apr 22, 2024
4 checks passed
@ijnek ijnek deleted the gc-spl-humble-rename branch April 25, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijnek @clalancette