remove soccer_object_msgs package that was deprecated in I-turtle #40701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ijnek <[email protected]>
github-actions
bot
added
the
rolling
ijnek
changed the title
mjcarroll
added
the
held for coordinated release
clalancette
approved these changes
Apr 24, 2024
clalancette
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Actually, scratch that. It appears to me like https://github.com/ijnek/soccer_visualization/blob/0a7c5e1a905bb1b4d990a083645626e37bb6c05c/soccer_marker_generation/package.xml#L14 still depends on this package. Are you also intending on removing soccer_visualization?
clalancette
approved these changes
Apr 24, 2024
|
Thanks @clalancette |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remove soccer_object_msgs from rolling and j-turtle. The package was deprecated in I-turtle, and was intended to be removed in J-turtle.
Resolves: ijnek/soccer_object_msgs#12