ortools_vendor: 9.9.0-2 in 'noetic/distribution.yaml' [bloom]

[Gonzalo-Mier]

Increasing version of package(s) in repository ortools_vendor to 9.9.0-2:

• upstream repository: https://github.com/Fields2Cover/ortools_vendor
• release repository: https://github.com/ros2-gbp/ortools_vendor-release.git
• distro file: noetic/distribution.yaml
• bloom version: 0.11.2
• previous version for package: null

[sloretz]

I'm going to close this assuming it was an unintentional release of a ROS 2 package into ROS 1.

If you do want a vendor package in ROS 1 then see REP 136. It describes how to add third party packages to ROS 1: https://ros.org/reps/rep-0136.html

[Gonzalo-Mier]

Hi @sloretz, this is intentionally released to ROS 1 noetic.

The release repo is on ros2-gbp to avoid code duplication, as ROS 2 requires their release repo to be on that group. Is there any problem with the group of the release repo?

This package works for ROS 1 and ROS 2 (tested using the Dockerfile in the repo), following the principle of being ROS distribution agnostic. It also complies with REP 136.

I see it's using ament_cmake

For ROS 1, cmake is used instead of ament_cmake

https://github.com/ros2-gbp/ortools_vendor-release/blob/c6d1d2519387a9e7cbf0bacbf34449c80ef46cdb/package.xml#L18-L26

https://github.com/ros2-gbp/ortools_vendor-release/blob/c6d1d2519387a9e7cbf0bacbf34449c80ef46cdb/CMakeLists.txt#L35-L47

[Gonzalo-Mier]

Thank you for your review

The change is intentional and allowed