Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ouster-ros: 0.10.3-1 in 'iron/distribution.yaml' [bloom] #38253

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Aug 16, 2023

Increasing version of package(s) in repository ouster-ros to 0.10.3-1:

ouster_msgs

* Add per package LICENSE file
* Contributors: Ussama Naal

ouster_ros

* Add per package LICENSE file
* manifest symbolic links as files
* Contributors: Ussama Naal

@github-actions github-actions bot added the iron Issue/PR is for the ROS 2 Iron distribution label Aug 16, 2023
@Yadunund
Copy link
Member

The linked release repo does not appear to be public.

And could you clarify the intention behind this PR #38252 which seems to release the same pkgs but under a different repo name?

@Samahu
Copy link
Contributor Author

Samahu commented Aug 16, 2023

Hi @Yadunund I just made the repo public. But during my review of the documentation it says that it is recommended that you create or host the release repository under https://github.com/ros2-gbp. How would I achieve that? Can we move the current release repository on https://github.com/ouster-lidar/ouster-ros-release to live under https://github.com/ros2-gbp later on?

Note that I have opened an issue to create a release team for Ouster: ros2-gbp/ros2-gbp-github-org#308

@Samahu
Copy link
Contributor Author

Samahu commented Aug 16, 2023

I have closed the PR #38252. This was my initial attempt to manually add the repo before I figured out that the bloom toolset would actually generate the pull request for you.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ouster-driver-package-removed-from-iron/32943/2

@tfoote
Copy link
Member

tfoote commented Aug 17, 2023

Please open a new issue on the organization management repository: https://github.com/ros2-gbp/ros2-gbp-github-org

There's a template for New Repository to create the ros2 release repo. It's highly recommended for Iron and mandatory for Rolling.

@Samahu
Copy link
Contributor Author

Samahu commented Aug 17, 2023

Please open a new issue on the organization management repository: https://github.com/ros2-gbp/ros2-gbp-github-org

There's a template for New Repository to create the ros2 release repo. It's highly recommended for Iron and mandatory for Rolling.

will do.

@Samahu
Copy link
Contributor Author

Samahu commented Aug 17, 2023

Please open a new issue on the organization management repository: https://github.com/ros2-gbp/ros2-gbp-github-org

ros2-gbp/ros2-gbp-github-org#315

@Samahu
Copy link
Contributor Author

Samahu commented Aug 17, 2023

Should I submit a new PR using bloom since we are changing the location of the release repository for ouster per ros2-gbp/ros2-gbp-github-org#315 from github.com/ouster-lidar org to github.com/ros2-gbp/ org?

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ouster-driver-package-removed-from-iron/32943/6

@tfoote
Copy link
Member

tfoote commented Aug 17, 2023

I believe that the release repository should be able to be imported and then this PR just edited to point to the new repository location.

@Samahu
Copy link
Contributor Author

Samahu commented Aug 17, 2023 via email

@methylDragon methylDragon merged commit 38d1ffc into ros:master Aug 21, 2023
4 checks passed
@Samahu Samahu deleted the bloom-ouster-ros-0 branch August 21, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants