Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting: modify yaml files to satisfy yamllint #38144

Merged
merged 2 commits into from
Aug 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
---
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
# only notify on security updates and not version updates.
open-pull-requests-limit: 0
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
# only notify on security updates and not version updates.
open-pull-requests-limit: 0
43 changes: 22 additions & 21 deletions .github/labeler-config.yaml
Original file line number Diff line number Diff line change
@@ -1,38 +1,39 @@
---
# Add 'noetic' label if any files in noetic/ folder are changed by a PR
noetic:
- noetic/*
- noetic/*

# Add 'humble' label if any files in humble/ folder are changed by a PR
humble:
- humble/*
- humble/*

# Add 'iron' label if any files in iron/ folder are changed by a PR
iron:
- iron/*
- iron/*

# Add 'rolling' label if any files in rolling/ folder are changed by a PR
rolling:
- rolling/*
- rolling/*

# Add 'rosdep' label if any files in rosdep/ folder are changed by a PR
rosdep:
- rosdep/*
- rosdep/*

# Add 'end-of-life' label if any files are in folders for versions that are no longer supported
end-of-life:
# ROS 1
- groovy/*
- hydro/*
- indigo/*
- jade/*
- kinetic/*
- lunar/*
- melodic/*
# ROS 2
- ardent/*
- bouncy/*
- crystal/*
- dashing/*
- eloquent/*
- foxy/*
- galactic/*
# ROS 1
- groovy/*
- hydro/*
- indigo/*
- jade/*
- kinetic/*
- lunar/*
- melodic/*
# ROS 2
- ardent/*
- bouncy/*
- crystal/*
- dashing/*
- eloquent/*
- foxy/*
- galactic/*
48 changes: 26 additions & 22 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
---
pull_request_rules:
- name: Comment on PRs with an end-of-life label
conditions:
- label=end-of-life
actions:
comment:
message: This pull request changes files for a ROS distribution that is no longer supported (End Of Life) and the distribution will not have any future syncs to include this change.
- name: Close on changes only to EOL folders
conditions:
- and:
- label=end-of-life
# Active ROS 1 distros
- label!=melodic
- label!=noetic
# Active ROS 2 distros
- label!=foxy
- label!=galactic
- label!=humble
- label!=rolling
# Other labels
- label!=rosdep
actions:
close:
- name: Comment on PRs with an end-of-life label
conditions:
- label=end-of-life
actions:
comment:
message: >
This pull request changes files for a ROS distribution
that is no longer supported (End Of Life)
and the distribution will not have any future syncs to include this change.
- name: Close on changes only to EOL folders
conditions:
- and:
- label=end-of-life
# Active ROS 1 distros
- label!=melodic
- label!=noetic
# Active ROS 2 distros
- label!=foxy
- label!=galactic
- label!=humble
- label!=rolling
# Other labels
- label!=rosdep
actions:
close:
7 changes: 5 additions & 2 deletions .github/workflows/build_test.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
---
name: Validate rosdistro
on:
# this is fine since gha runs with yaml 1.2
on: # yamllint disable-line rule:truthy
push:
branches: ['master']
pull_request:
Expand All @@ -22,7 +24,8 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Fetch upstream (to enable diff)
run: |
git remote add unittest_upstream_comparison https://github.com/ros/rosdistro.git || git remote set-url unittest_upstream_comparison https://github.com/ros/rosdistro.git
git remote add unittest_upstream_comparison https://github.com/ros/rosdistro.git \
|| git remote set-url unittest_upstream_comparison https://github.com/ros/rosdistro.git
git fetch --no-tags --depth=1 unittest_upstream_comparison master
- name: Install Dependencies
run: |
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/labeler.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
---
name: "Pull Request Labeler"
on:
# this is fine since gha runs with yaml 1.2
on: # yamllint disable-line rule:truthy
- pull_request_target

permissions:
Expand Down
32 changes: 21 additions & 11 deletions .github/workflows/stale_labeler.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1,29 @@
---
name: 'Label inactive PRs as stale'

on:
# this is fine since gha runs with yaml 1.2
on: # yamllint disable-line rule:truthy
schedule:
- cron: '0 11 * * *' # runs at 11am UTC every day => early morning in US
- cron: '0 11 * * *' # runs at 11am UTC every day => early morning in US

jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v8 # https://github.com/marketplace/actions/close-stale-issues
with:
stale-pr-label: 'stale'
stale-pr-message: "This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our [contributing policy](https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md). It's been labeled \"stale\" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label."
days-before-pr-stale: 14
days-before-pr-close: -1 # don't close PRs automatically
days-before-issue-stale: -1 # don't label issues as stale
days-before-issue-close: -1 # don't close issues automatically
exempt-pr-labels: 'persistent'
- uses: actions/stale@v8 # https://github.com/marketplace/actions/close-stale-issues
with:
stale-pr-label: 'stale'
stale-pr-message: >
This PR hasn't been activity in 14 days.
If you are still are interested in getting it merged
please provide an update.
Otherwise it will likely be closed by a rosdistro maintainer
following our [contributing policy](https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md).
It's been labeled "stale" for visibility to the maintainers.
If this label isn't appropriate,
you can ask a maintainer to remove the label and add the 'persistent' label.
days-before-pr-stale: 14
days-before-pr-close: -1 # don't close PRs automatically
days-before-issue-stale: -1 # don't label issues as stale
days-before-issue-close: -1 # don't close issues automatically
exempt-pr-labels: 'persistent'
5 changes: 3 additions & 2 deletions .yamllint
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
extends:
default

Expand All @@ -8,10 +9,10 @@ rules:
rosdep/*.yaml
indentation:
spaces: consistent
indent-sequences: no
indent-sequences: false
key-duplicates: enable
line-length:
max: 125
allow-non-breakable-words: yes
allow-non-breakable-words: true
ignore: |
rosdep/*.yaml
Loading