Add catch2 to rosdep rules #38088
Merged
Add catch2 to rosdep rules #38088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Weaver <[email protected]>
cottsay
reviewed
Jul 28, 2023
Co-authored-by: Scott K Logan <[email protected]>
cottsay
previously requested changes
Aug 1, 2023
There was a problem hiding this comment.
The linters found 3 issues. Please take a look at the files changed tab when CI fails like this - sometimes it's super clear what caused the failure.
rosdep/base.yaml
Outdated
| gentoo: [catch] | ||
| nixos: [catch2] | ||
| opensuse: [Catch2] | ||
| ubuntu: [catch2] |
There was a problem hiding this comment.
Linter says this isn't in focal.
Suggested change
| ubuntu: [catch2] | |
| ubuntu: [catch2] |
cottsay
reviewed
Aug 1, 2023
cottsay
reviewed
Aug 1, 2023
Thank you, I didn't know about that feature. I'll clean this up today. |
Co-authored-by: Scott K Logan <[email protected]>
audrow
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add the following dependency to the rosdep database.
Package name:
catch2
Package Upstream Source:
https://github.com/catchorg/Catch2
Purpose of using this:
Catch2 is an alternative to gtest
Distro packaging links: