Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rhel to the PR template #37231

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented May 13, 2023

When working on #37226, I saw in the logs rhel was suggested, but it's not part of the PR template. I used the same package URL for rhel as recommended in the logs.

Let me know if you think it should be added.

Signed-off-by: Ryan Friedman <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two questions about this:

  1. Does this include packages that would be included as part of EPEL/crb? That is a valid places for packages to come from for RHEL.
  2. Do we really have to hard-code this to 9.2? It means that we'll have to update this template every time RHEL does a new update. Is there another URL we can use that doesn't hard-code this?

@clalancette
Copy link
Contributor

Also, @cottsay can you take a look here?

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented May 16, 2023

I have two questions about this:

  1. Does this include packages that would be included as part of EPEL/crb? That is a valid places for packages to come from for RHEL.
  2. Do we really have to hard-code this to 9.2? It means that we'll have to update this template every time RHEL does a new update. Is there another URL we can use that doesn't hard-code this?

Sorry, I am not able to answer either of those. I was just copying what the CI was telling me. I'm not a rhel user. From my research, it seems like you need an account to search packages on the official registry. Perhaps we just link that?

@cottsay cottsay self-requested a review May 16, 2023 15:16
@quarkytale quarkytale added the more information needed Maintainers have asked for additional information label May 22, 2023
@cottsay cottsay self-assigned this May 31, 2023
@clalancette
Copy link
Contributor

@cottsay Friendly ping here, it would be nice to figure out how to make RHEL a valid target without hard-coding the exact point version.

@github-actions
Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Jul 14, 2023
@cottsay
Copy link
Member

cottsay commented Jul 27, 2023

Question for @clalancette and @nuclearsandwich - how would you feel about recommending an unofficial package database like pkgs.org?

@clalancette
Copy link
Contributor

Question for @clalancette and @nuclearsandwich - how would you feel about recommending an unofficial package database like pkgs.org?

I personally think that is fine; it gives relevant and correct information, as far as I know (I use it myself to double-check some rosdep keys).

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Jul 28, 2023
@nuclearsandwich
Copy link
Member

how would you feel about recommending an unofficial package database like pkgs.org?

I'm not opposed to using "unofficial" resources as long as there is a good track record of accuracy, especially if they're more accessible than the official databases.

@github-actions
Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Aug 12, 2023
@mjcarroll mjcarroll merged commit c03ee6a into ros:master Aug 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more information needed Maintainers have asked for additional information stale Issue/PR hasn't been active in a while and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants