-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rhel to the PR template #37231
Add rhel to the PR template #37231
Conversation
Signed-off-by: Ryan Friedman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two questions about this:
- Does this include packages that would be included as part of EPEL/crb? That is a valid places for packages to come from for RHEL.
- Do we really have to hard-code this to
9.2
? It means that we'll have to update this template every time RHEL does a new update. Is there another URL we can use that doesn't hard-code this?
Also, @cottsay can you take a look here? |
Sorry, I am not able to answer either of those. I was just copying what the CI was telling me. I'm not a |
@cottsay Friendly ping here, it would be nice to figure out how to make RHEL a valid target without hard-coding the exact point version. |
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
Question for @clalancette and @nuclearsandwich - how would you feel about recommending an unofficial package database like pkgs.org? |
I personally think that is fine; it gives relevant and correct information, as far as I know (I use it myself to double-check some rosdep keys). |
I'm not opposed to using "unofficial" resources as long as there is a good track record of accuracy, especially if they're more accessible than the official databases. |
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
Co-authored-by: Scott K Logan <[email protected]>
When working on #37226, I saw in the logs
rhel
was suggested, but it's not part of the PR template. I used the same package URL forrhel
as recommended in the logs.Let me know if you think it should be added.