Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python-attrs-pip for Ubuntu #36888

Closed
wants to merge 1 commit into from

Conversation

zultron
Copy link
Contributor

@zultron zultron commented Apr 17, 2023

Replace Ubuntu in the python-attrs-pip key, removed in commit 59517bc.

@zultron zultron requested a review from a team as a code owner April 17, 2023 17:33
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Apr 17, 2023
Replace Ubuntu in the `python-attrs-pip` key, removed in commit
59517bc.
@zultron
Copy link
Contributor Author

zultron commented Apr 17, 2023

CI broke on the first hunk of the original PR; that's now backed out, and the PR description updated.

I'm still not sure if the python-attrs key can be a replacement for python-attrs-pip. In Ubuntu Focal, what would the python-attrs key install, the python-attr Debian package or the attrs pip package?

python-attrs:
  debian: [python-attr]
  gentoo: [dev-python/attrs]
  nixos: [pythonPackages.attrs]
  ubuntu:
    '*':
      packages: [python-attr]
      pip:
        packages: [attrs]

@nuclearsandwich
Copy link
Member

Hmmm. I think that the status quo is incorrect or at least odd. And opened #36893 to address that in a minimally compatible way.

@tfoote was the intent in removing the pip definition for just Ubuntu made under the assumption that the pip key was also only there to backfill for Trusty? If that's the case I think we could consider removing it for Debian as well.

@zultron what platforms are you on that you're relying on this key? All ROS platforms which support python2 are nearing the end of their support, so the best thing to do if you intend to keep using them may be to switch to a fixed copy of the rosdep database.

@tfoote
Copy link
Member

tfoote commented Apr 18, 2023

The fix in #36893 looks like the right fix. The pip rule was used before the debian packages were available. And the debian rule could be extended to support older platforms. But I think that now all the older platforms are eol. So I removed the pip rule because all the expected platforms are now unsupported. So I think that we should keep the pip rule removed.

@mjcarroll
Copy link
Member

Since there hasn't been a response here, I'm going to close this as fixed by #36893

@mjcarroll mjcarroll closed this May 3, 2023
zultron added a commit to zultron/hw_device_mgr that referenced this pull request May 15, 2023
zultron added a commit to zultron/hw_device_mgr that referenced this pull request May 15, 2023
zultron added a commit to zultron/hw_device_mgr that referenced this pull request May 15, 2023
zultron added a commit to zultron/hal_ros_control that referenced this pull request May 30, 2023
- Fix CI Docker image namespace, following upstream [1] (possibly
  temporary)

- Update CI Docker image and CI config to Humble/Jammy

- Fix `clang-format` package name for Jammy

- Update pre-commit GH action tag to latest 3.0.0

- Fix Cloudsmith.io repo install

- Fix `python-attrs-pip` rosdep key while waiting on [2] and [3]

[1]: moveit/moveit2#1908
[2]: ros/rosdistro#36888
[3]: ros/rosdistro#36893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants