-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Alpine package alias names in rosdep_repo_check #31565
Conversation
FYI @russkel |
Thanks for that @at-wat. The only change I'd recommend is changing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the apk installer and apk detector in rosdep handle these aliases?
They call actual |
Co-authored-by: Scott K Logan <[email protected]>
While
|
@cottsay opened a PR on rosdep: ros-infrastructure/rosdep#848 |
@cottsay ros-infrastructure/rosdep#848 addresses your comment. Please take a look when you have time. |
The rosdep PR has been merged. @cottsay Can you loop back on this? |
We're trying to get a rosdep release out soon. Then this can be merged. |
@cottsay, can this be merged yet? |
No. We still need a rosdep release for the affected keys to work. |
This PR fixes
rosdep_repo_check
test to handle alias package names on Alpine Linux.For example on the recent version of Alpine including
edge
, packageboost
does not exist butboost1.77
package provides boost with alias name ofboost
.In such case, entry in APKINDEX is like:
References