Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roslibpy-pip #30310

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Add roslibpy-pip #30310

merged 1 commit into from
Jul 26, 2021

Conversation

F1iX
Copy link
Contributor

@F1iX F1iX commented Jul 22, 2021

Please add the following dependency to the rosdep database.

Package name:

roslibpy

Package Upstream Source:

https://github.com/gramaziokohler/roslibpy

Purpose of using this:

Needed for packages using rosbridge_suite, e.g. https://gitlab-extern.ivi.fraunhofer.de/keppler/ros_to_rosbridge

Distro packaging links:

Links to Distribution Packages

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@F1iX F1iX requested a review from a team as a code owner July 22, 2021 13:41
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to add assuming that there's no plans for it to be released upstream into debian or ubuntu packages. Because it's pip based it will never support releasing binary packages based on it.

@tfoote tfoote added the rosdep Issue/PR is for a rosdep key label Jul 26, 2021
@cottsay cottsay merged commit 29b3847 into ros:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants