Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ur_client_library: 0.2.1-1 in 'foxy/distribution.yaml' [bloom] #29451

Merged
merged 1 commit into from
May 10, 2021

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented May 6, 2021

Increasing version of package(s) in repository ur_client_library to 0.2.1-1:

ur_client_library

* Run ci also for ROS2 foxy
* Prepare package.xml and cmakelists for ROS2
* Add downstream workspace
* Contributors: Felix Exner, Lennart Puck

@fmauch fmauch requested a review from jacobperron as a code owner May 6, 2021 15:02
@nuclearsandwich
Copy link
Member

@fmauch because of the complicated license structure of this repository it makes sense to me to add file= attributes to the license tags in the package.xml (as described in REP-149 to pinpoint where the license files for the subprojects are located.

Other than the above this meets the review criteria for a new package in Foxy.

@fmauch
Copy link
Contributor Author

fmauch commented May 6, 2021

That seems to be a good idea. What would be the release workflow for this? I would probably make a new release v0.2.2 with those changes?


Edit: See UniversalRobots/Universal_Robots_Client_Library#63

@jacobperron
Copy link
Contributor

Unless there's a different opinion, I think it's okay to hold off on making a new release. As long as the license-related changes are in the source branch, folks should be able to find that information.

@nuclearsandwich
Copy link
Member

Unless there's a different opinion, I think it's okay to hold off on making a new release. As long as the license-related changes are in the source branch, folks should be able to find that information.

My soft objection would be that the rosdistro_cache.yaml only stores the release package.xml files not those for the source repository and that the package.xml installed with the package would also be missing that added information but given that the current changes are already released in other ROS distributions I'm actually going to turn that soft objection into a recommendation for the next round of releases. :shipit:

@nuclearsandwich nuclearsandwich merged commit f19f416 into ros:master May 10, 2021
@fmauch fmauch deleted the bloom-ur_client_library-4 branch May 20, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants