Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During migration, fail gracefully with unreleased repos #29214

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Apr 20, 2021

This will prevent a KeyError from causing the entire script to exit when encountering a repository release mapping which has no version, such as this one:

release:
packages:
- swri_console_util
- swri_dbw_interface
- swri_geometry_util
- swri_image_util
- swri_math_util
- swri_opencv_util
- swri_prefix_tools
- swri_roscpp
- swri_route_util
- swri_serial_util
- swri_system_util
- swri_transform_util
tags:
release: release/rolling/{package}/{version}
url: https://github.com/swri-robotics-gbp/marti_common-release.git

@cottsay cottsay self-assigned this Apr 20, 2021
@cottsay cottsay merged commit 55fdf4e into ros:master Apr 20, 2021
@cottsay cottsay deleted the migration_no_version branch April 20, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants