Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version Nerian ROS node, including first version for ROS2 #29135

Merged
merged 6 commits into from
Apr 14, 2021

Conversation

nerian-vision
Copy link
Contributor

Unfortunately bloom refuses to generate automatic pull requests at the moment, so here's a manual submission. We released the first version of the node for our 3D cameras for ROS2. Also we updated the packages for ROS1.

Package name:

nerian_stereo

Package Upstream Source:

https://github.com/nerian-vision/nerian_stereo_ros2.git

Purpose of using this:

This is the ROS2 version of the node for Nerian's 3D cameras
Distro packaging links:

@cottsay cottsay added kinetic melodic Issue/PR is for the ROS 1 Melodic distribution noetic Issue/PR is for the ROS 1 Noetic distribution labels Apr 14, 2021
@tfoote
Copy link
Member

tfoote commented Apr 14, 2021

In the future please submit these as separate pull requests for each distro. Different distros have different release timelines and sync freeze times. As well as a potential necessary rollback is much harder to track if it's cross coupled. You got lucky, but if you were off by one day Foxy sync freeze would be blocking this merge.

Related the Kinetic update is highly urgent because we are preparing for the final kinetic sync. All releases should be prepared by April 20th and we will have a long soak time until April 26th. Please make sure to test from the testing repository to make sure that there's no regressions after this is released. You can get more info from this thread on ROS Discourse

@tfoote tfoote merged commit 1608308 into ros:master Apr 14, 2021
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/releasing-a-package-for-ros2/19965/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
melodic Issue/PR is for the ROS 1 Melodic distribution noetic Issue/PR is for the ROS 1 Noetic distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants