Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python3-junitparser as a rosdep key #29019

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

danthony06
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

python3-junitparser

Package Upstream Source:

https://github.com/weiwei/junitparser

Purpose of using this:

The dependency is used as part of a testing pipeline, and it would be nice to have support for parsing results from this common unit testing framework.

Distro packaging links:

Links to Distribution Packages

Distro A, OPSEC #4584

@danthony06 danthony06 requested a review from a team as a code owner April 6, 2021 23:25
rosdep/python.yaml Outdated Show resolved Hide resolved
rosdep/python.yaml Outdated Show resolved Hide resolved
rosdep/python.yaml Outdated Show resolved Hide resolved
@danthony06
Copy link
Contributor Author

@hidmic I believe I fixed all of the issues you raised. Sorry for missing those issues on the first commit.

rosdep/python.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic requested a review from cottsay April 12, 2021 17:11
@cottsay cottsay merged commit fa91ebc into ros:master Apr 14, 2021
@cottsay cottsay added the rosdep Issue/PR is for a rosdep key label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants