Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update clean_rosdep_yaml script to represent null values properly #26711

Merged
merged 1 commit into from
Sep 28, 2020
Merged

update clean_rosdep_yaml script to represent null values properly #26711

merged 1 commit into from
Sep 28, 2020

Conversation

niomate
Copy link
Contributor

@niomate niomate commented Sep 26, 2020

Tried my best to update the clean script such that null values are not removed when the script is run. If the change in formatting is an issue, I can revert it easily.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement to the script. As such, I'm going to approve and merge it. Thanks for the contribution.

However, I will point out that this isn't sufficient to make this script work properly. In particular, the script blindly removes quotes, which are actually needed in several cases in the rosdep base.yaml. So this will still need follow-up.

@clalancette clalancette merged commit d91af18 into ros:master Sep 28, 2020
@niomate
Copy link
Contributor Author

niomate commented Sep 28, 2020

Yes, I think this is happening inside the quote_if_necessary which does some weird stuff and I could not really find out what the reason for the way this was implemented is.
Do you know when quotes should be applied ?

@clalancette
Copy link
Contributor

Do you know when quotes should be applied ?

I know that they are needed e.g. on this line:

gentoo: ['www-servers/apache[apache2_mpms_prefork]']
. At least one rule is that if they are already in a list, they should not be touched. But I don't know a general rule on when they should and should not be applied.

@niomate
Copy link
Contributor Author

niomate commented Sep 28, 2020

Do you know where I could get more information ? Or should I just read through the yaml files and try to find a pattern if I want to contribute this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants