Add ur_client_library #26529
Add ur_client_library #26529
Conversation
There was a problem hiding this comment.
A few questions before merging, but it lgtm:
- The LICENSE file says Apache, and the package.xml Apache/BSD-2clause/Zlib, is the package multi-licensed? If the other listed licenses are from dependencies, it would be great to clarify that in the package.xml.
- was the release done with bloom?
| release: release/melodic/{package}/{version} | ||
| url: https://github.com/UniversalRobots/Universal_Robots_Client_Library-release.git | ||
| version: 0.1.0-1 | ||
| source: |
There was a problem hiding this comment.
can you add a doc entry too?
There was a problem hiding this comment.
That would require adding a rosdoc.yaml file and mainpage.dox file through the release repository as described here, right?
I didn't want to clutter the source repository with that, as it is quite ROS specific. On the other hand, we have a package.xml file there, already...
There was a problem hiding this comment.
Sorry, I have absolutely no experience with the doc generation...
There was a problem hiding this comment.
As I have already added a doc entry for the Universal Robots ROS Driver which created also documentation for contained packages, which don't have a respective rosdoc.yaml and mainpage.dox such as ur_calibration it should be fine adding a doc entry without explicitly setting this up.
There was a problem hiding this comment.
I've added a doc section to this PR.
There are upstream components included which are released under the respective licenses. I'll clarify this in more detail.
Yes, however, aquiring the GH token did not work, which is why I made the PR by hand. |
Thanks!
Sounds good |
There was a problem hiding this comment.
This LGTM.
It would be good, however, if your CMakeLists.txt installed the package.xml you're including in the repository. It looks like maybe the CMakeLists.txt is aware if whether it is in a ROS build or not, so maybe you could conditionally install it based on that. If that isn't the case, it might also be possible to patch the CMakeLists.txt in the release repository.
| release: release/melodic/{package}/{version} | ||
| url: https://github.com/UniversalRobots/Universal_Robots_Client_Library-release.git | ||
| version: 0.1.0-1 | ||
| source: |
There was a problem hiding this comment.
Sorry, I have absolutely no experience with the doc generation...
|
@ivanpauno I've added a license section to the README to clarify all licenses included in this package. Also, I've added an install statement for the If you think, that this should be sufficient, I'll release a version 0.1.1 including those changes. |
82599bd
to
57b16a0
Compare
|
Everything should be setup accordingly. |
We are currently in the process of splitting the client library from the ur_robot_driver itself. The client library shall be released first so that users can install it using rosdep instead of having to build their workspace in isolation because the library isn't a catkin package.