Add in the BSD license. #26055
Merged
Add in the BSD license. #26055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make it clear what license the code in this repository should be under. While I was here, I also took the liberty of adding the BSD license clause header to the files that were clearly written by Open Robotics employees. This included relicensing one file from Apache 2.0 to BSD, but that was writting completely by Tully so it should be fine. Signed-off-by: Chris Lalancette <[email protected]>
chapulina
approved these changes
Aug 5, 2020
cottsay
reviewed
Aug 6, 2020
Signed-off-by: Chris Lalancette <[email protected]>
tfoote
approved these changes
Aug 13, 2020
wjwwood
approved these changes
Aug 13, 2020
|
All right, I think we've had broad agreement that this is OK to do here. I'm going to go ahead and merge this. Thanks everyone for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, there have been some questions raised on what license this repository is under. While it is largely a set of configuration files for the various ROS distributions, there is also a bunch of code in here. I think we should add a license to clarify the situation for this repository.
I've gone with the BSD license here as it is the most broad, there are already a couple of files in this repository that claim it, and it is compatible with both ROS 1 and ROS 2. While adding in the top-level LICENSE file, I took the liberty of adding the BSD license clause header to the files that were written by current Open Robotics employees. This included relicensing one file from Apache 2.0 to BSD, but that was written completely by @tfoote so it should be fine.
I did not add the license header to files that had one or more authors outside of Open Robotics. I'm not sure whether we can add that header, or whether we need explicit permission from the outside authors.
@ros2/team I'm looking for opinions on whether this is a viable thing to do, and whether I've gone about it properly.
@chapulina FYI