Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups for migration tools. #25026

Merged
merged 4 commits into from
May 24, 2020
Merged

Fixups for migration tools. #25026

merged 4 commits into from
May 24, 2020

Conversation

nuclearsandwich
Copy link
Member

When porting this script into the rosdistro repo I missed a few things. I've been doing some pre-flight tests with the current script and saw these issues.

  • Removed a conditional continue causing the script to only run on repositories named gazebo_ros_packages 😅
  • Be sure to push the last set of tracks.yaml modifications to the release repository.
  • Rewrite release tags to use the destination rosdistro name.
  • Fix an f-string's missing f.

@nuclearsandwich nuclearsandwich self-assigned this May 22, 2020
@nuclearsandwich nuclearsandwich merged commit 11b231a into ros:master May 24, 2020
@nuclearsandwich nuclearsandwich deleted the fixup-migration-tools branch May 24, 2020 01:23
sloretz pushed a commit that referenced this pull request Aug 5, 2020
@nuclearsandwich @sloretz
Fixups for migration tools. (#25026)
d3a943a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees

@nuclearsandwich nuclearsandwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuclearsandwich @tfoote