Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add focal version for some base packages #24193

Merged
merged 1 commit into from
Mar 30, 2020
Merged

add focal version for some base packages #24193

merged 1 commit into from
Mar 30, 2020

Conversation

flixr
Copy link
Contributor

@flixr flixr commented Mar 22, 2020

Add ubuntu distro focal for some base packages:

  • libfcl-dev
  • libgsl
  • libpng-dev
  • protobuf

@flixr flixr requested a review from a team as a code owner March 22, 2020 17:48
tfoote
tfoote requested changes Mar 22, 2020
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look like they have been stable across the last 2-3 LTS releases. To that end lets switch to use a wildcard notation for everything that's the same as the current release and only call out the older ones on the expectation that they will continue to remain static and will save us future maintenance.

@clalancette clalancette added the rosdep Issue/PR is for a rosdep key label Mar 23, 2020
@flixr
add focal version for some base packages
51519bc 
and switch to wildcard notation where the names have been stable for the
last couple of releases
@flixr
Copy link
Contributor Author

flixr commented Mar 23, 2020

good idea, done...

@flixr flixr requested a review from tfoote March 23, 2020 19:30
tfoote
tfoote approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. lgtm

@tfoote tfoote requested a review from a team March 25, 2020 00:13
@clalancette clalancette merged commit 2df59f2 into ros:master Mar 30, 2020
@flixr flixr deleted the focal_base branch March 30, 2020 16:18
sloretz pushed a commit that referenced this pull request Aug 5, 2020
@flixr @sloretz
add focal version for some base packages (#24193)
1624f57 
and switch to wildcard notation where the names have been stable for the
last couple of releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flixr @clalancette @tfoote