Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librealsense2: 2.33.1-2 in 'kinetic/distribution.yaml' [bloom] #23997

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

doronhi
Copy link
Contributor

@doronhi doronhi commented Mar 8, 2020

Increasing version of package(s) in repository librealsense2 to 2.33.1-2:

@doronhi doronhi requested a review from tfoote as a code owner March 8, 2020 07:04
@doronhi
Copy link
Contributor Author

doronhi commented Mar 8, 2020

commit aa5b35b updates version in the melodic branch.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put an update for two different ROS distributions in the same pull request. They aren't on the same sync schedule, so it may end up that this PR couldn't be merged because one or the other is in freeze. Right now they are both not frozen, but please keep this in mind for the future.

@clalancette clalancette merged commit 592aa08 into ros:master Mar 9, 2020
@doronhi
Copy link
Contributor Author

doronhi commented Mar 10, 2020

I appreciate the remark and will keep that in mind.
Thanks.

at-wat pushed a commit to alpine-ros/rosdistro that referenced this pull request Mar 12, 2020
…3997)

* librealsense2: 2.33.1-2 in 'kinetic/distribution.yaml' [bloom]

* update librealsense2 version to 2.33.1-2
@doronhi doronhi deleted the bloom-librealsense2-7 branch August 9, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants