Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[melodic] Add the upstream source for cartographer_ros and cartographer #23819

Merged
merged 1 commit into from
Feb 20, 2020
Merged

[melodic] Add the upstream source for cartographer_ros and cartographer #23819

merged 1 commit into from
Feb 20, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Feb 20, 2020

Add the upstream repository for completeness.

This is motivated by that https://aka.ms/ros project currently is not able to use rosinstall_generator to pull down the upstream repository information because of the missing information and has to maintain a separate .rosinstall file for cartographer related builds.

@seanyen
Copy link
Contributor Author

seanyen commented Feb 20, 2020

@clalancette This is ready for review and merge. Thanks!

@mikaelarguedas
Copy link
Member

The code released in melodic does not match the master branch and does not compile as is: http:https://build.ros.org/job/Mdev__cartographer_ros__ubuntu_bionic_amd64/1
http:https://build.ros.org/job/Mdev__cartographer__ubuntu_bionic_amd64/1

IIRC the code on the upstream repository never compiled as is on the farm, that's the reason we have patches on the release repository and never added a source entry here.
If I understood correctly, the source repositories added in this PR are currently unmaintained so I would expect the code from the master branch to not build successfully in the foreseeable future. Therefore I suggest reverting this PR

@clalancette FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants