Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-mypy #21776

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Add python3-mypy #21776

merged 3 commits into from
Jul 17, 2019

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Jul 17, 2019

No description provided.

Signed-off-by: Kyle Fazzari <[email protected]>
@kyrofa kyrofa requested a review from a team as a code owner July 17, 2019 19:21
@jacobperron
Copy link
Contributor

Following contribution guidelines, here are the web listings:

I believe the reason for adding this dependency is so that we can add mypy tests to Python packages.

I think we should add an additional rule for Debian Stretch since it a recommended support platform.
I think adding a rule for Gentoo would be good too.

@kyrofa
Copy link
Contributor Author

kyrofa commented Jul 17, 2019

I think we should add an additional rule for Debian Stretch since it a recommended support platform.

Done. However, Stretch is pretty old, where are you getting that info?

EDIT: ignore me, it's REP 3. Still old, haha.

@nuclearsandwich
Copy link
Member

Added an Archlinux key https://www.archlinux.org/packages/community/any/mypy/

@kyrofa
Copy link
Contributor Author

kyrofa commented Jul 17, 2019

Thanks @nuclearsandwich!

@jacobperron jacobperron merged commit 4560370 into ros:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants