Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #21646

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Update CONTRIBUTING.md #21646

merged 1 commit into from
Jun 28, 2019

Conversation

pbeeson
Copy link
Contributor

@pbeeson pbeeson commented Jun 28, 2019 •
edited
Loading

Improve instructions for requested info in a rosdep PR.

clalancette
clalancette approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

nuclearsandwich
nuclearsandwich approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @pbeeson.

@nuclearsandwich nuclearsandwich merged commit 18e3b9a into ros:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbeeson @clalancette @nuclearsandwich