Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating information for the microstrain_3dm_gx5_45 ROS package #21320

Merged
merged 4 commits into from
May 29, 2019

Conversation

bsb808
Copy link
Contributor

@bsb808 bsb808 commented May 21, 2019

Correcting the source repos. URL and adding package to kinetic and melodic.

indigo/distribution.yaml Outdated Show resolved Hide resolved
@sloretz sloretz dismissed their stale review May 28, 2019 23:12

Comment addressed

@@ -6722,6 +6722,16 @@ repositories:
url: https://github.com/xuefengchang/micros_swarm_framework.git
version: master
status: developed
microstrain_3dm_gx5_45:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not referenced elsewhere, but it would be good to change the name at this level too for easier searching and consistency.

Also in the other 2 distros.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the catch. Changed the reference to "microstrain_mips" so that naming is consistent.

@tfoote tfoote merged commit 03e1839 into ros:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants