Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define which sources are valid for rosdep keys #21252

Merged
merged 8 commits into from
Jul 9, 2019
Merged

Define which sources are valid for rosdep keys #21252

merged 8 commits into from
Jul 9, 2019

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented May 17, 2019

No description provided.

@tfoote tfoote mentioned this pull request May 17, 2019
Merged
@tfoote
Copy link
Member Author

tfoote commented May 17, 2019

@cottsay @allenh1 @russkel could you take a few moments to fill in the requirements for Fedora, Gentoo, and Alpine as amendments to this PR?

@tfoote tfoote added the rosdep Issue/PR is for a rosdep key label May 17, 2019
@allenh1
Copy link
Contributor

allenh1 commented May 17, 2019

@tfoote I am ready to push but don't have write access here, actually. I can email you a patch to git am into your branch or PR it into yours.

Let me know your preference.

@tfoote
Copy link
Member Author

tfoote commented May 21, 2019

A PR into this branch would be great.

@allenh1 allenh1 mentioned this pull request May 22, 2019
Merged
allenh1
allenh1 approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clalancette
Add commas
0eb282b 
Also be consistent with usage of `or`
@nuclearsandwich
Copy link
Member

I have added an Archlinux entry. The link to the AUR installer issue in rosdep may be more information than needed.

@russkel
Copy link
Contributor

russkel commented Jul 2, 2019

Pedantic: I believe it's referred to as Arch Linux

@nuclearsandwich
Copy link
Member

Pedantic: I believe it's referred to as Arch Linux

I swear they change it every few years just to mess with me.

@tfoote
Copy link
Member Author

tfoote commented Jul 9, 2019

Thanks for all the updates. This looks like a better state than we had before. More followups are welcome too if we need to iterate.

@tfoote tfoote merged commit 38a3ab4 into master Jul 9, 2019
@tfoote tfoote deleted the tfoote-rosdep-sources branch July 9, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@allenh1 allenh1 allenh1 approved these changes

Assignees
No one assigned
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tfoote @allenh1 @nuclearsandwich @russkel @clalancette @cottsay