ml_classifiers: 1.0.0-0 in 'crystal/distribution.yaml' [bloom]

[JWhitleyWork]

Increasing version of package(s) in repository ml_classifiers to 1.0.0-0:

• upstream repository: https://github.com/astuff/ml_classifiers.git
• release repository: https://github.com/astuff/ml_classifiers-release.git
• distro file: crystal/distribution.yaml
• bloom version: 0.7.2
• previous version for package: null

ml_classifiers

* Merge pull request #2 <https://github.com/astuff/ml_classifiers/issues/2> from astuff/ros-transition
  ROS2 Hybrid Package - now builds in ROS Kinetic/Melodic and ROS2 Crystal
* ROS2: Making classifier_server a class.
* Creating separate ros1/ros2 xml files.
* ROS1: Removing roslint in favor of ROS2 linting.
* ROS2: Disabling boost in pluginlib.
* ROS2: Updating copyrights to conform to ament_copyright.
* ROS2: Fixing cmake exports.
* Contributors: Joshua Whitley

[JWhitleyWork]

@nuclearsandwich or @tfoote - Can you apply a revert on this, #20840, and #20839? The build is failing on the build farm and I know why - I forgot that I built this using a version of bloom that hasn't been released upstream yet. It requires ros-infrastructure/bloom#527 and ros-infrastructure/bloom#519 to be merged first. Sorry about that.

[nuclearsandwich]

It requires ros-infrastructure/bloom#527 and ros-infrastructure/bloom#519 to be merged first

The next release of bloom (0.8.0) is likely to include both of those PRs and should be released by tomorrow.

Aside from being procedurally fraught using a modified bloom shouldn't affect what happens once things get onto the buildfarm as long as the generated artifacts are valid. I opened the revert PRs and then realized that the bloom version shouldn't affect those. The Melodic and Kinetic builds are passing and the Crystal build is failing because of a CMake issue (see log).

I can revert the crystal one if you like but it might be worth letting them stand and re-releasing the fixed version once the CMake issue is resolved.

[nuclearsandwich]

@JWhitleyAStuff regarding your comment #20850 (comment)

Since merge, Kinetic, Lunar, and Melodic are failing (though I'm not sure why Lunar is failing, because I didn't release a new version for Lunar) on https://build.ros.org/. Why not necessary?

I don't see build failures for Kinetic and Melodic

• https://build.ros.org/view/Kbin_uX64/job/Kbin_uX64__ml_classifiers__ubuntu_xenial_amd64__binary/
• https://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__ml_classifiers__ubuntu_bionic_amd64__binary/

[nuclearsandwich]

Ah, you must be referring to the dev jobs!

Those jobs are based on the HEAD of the configured devel branch so if it's the same for kinetic, lunar, and melodic it will affect all three regardless of release.

[JWhitleyWork]

OK, cool. I didn't know about the bloom release. I did notice the error in the Crystal log that was unrelated. Also, I see what you're saying about bloom. It shouldn't be used in the build process past release. And yes, the dev jobs are failing, though it looks like the bin jobs are fine. Those failures should be bloom-related, yeah? Go ahead and cancel the reverts and we can try to troubleshoot the CMake error separately for Crystal. Thanks for the help, mate.

[nuclearsandwich]

Those failures should be bloom-related, yeah?

Looking at the logs, there would seem to be still another place where conditional dependencies aren't fully handled. Something in those jobs is looking for ament_cmake, which is not available in ROS 1.

[JWhitleyWork]

Yeah, I guess I assumed it was bloom - probably not. Do you know where they keep the job scripts for the build farm?

[nuclearsandwich]

Do you know where they keep the job scripts for the build farm?

The repository is here https://github.com/ros-infrastructure/ros_buildfarm. I think an issue there linking to your source and the failing dev jobs would be really helpful. I'm about to wrap up for today but tomorrow I can provide guidance if you'd like to contribute a PR and haven't already found the relevant content in the repo.

[JWhitleyWork]

Thanks!