Add explaination of why source version tag must be a branch #20286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
added a commit
that referenced
this pull request
Feb 12, 2019
This is capturing the requirements from #20286 more clearly.
nuclearsandwich
approved these changes
Feb 13, 2019
tfoote
added a commit
that referenced
this pull request
Feb 20, 2019
* Update url validity check with better messages and tag priority This is capturing the requirements from #20286 more clearly. * Allow source entries to be tags in some cases. If test_pull_requests and test_commits are both explicitly false, this will allow the source entry to contain tags. * Add support for using commit ids as version. Co-authored-by: Kei Okada <[email protected]> * Always clean up tempdir. * Only check commit id if the version matches a 40 char id string. * fixing check priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.