Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added avaliable ubuntu bionic packages #18634

Merged
merged 5 commits into from
Aug 8, 2018
Merged

added avaliable ubuntu bionic packages #18634

merged 5 commits into from
Aug 8, 2018

Conversation

jorritsmit
Copy link
Contributor

These packages are available in the bionic repository

tfoote
tfoote previously requested changes Jul 24, 2018
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either add Y Z A as well as B.

Most of these look like they'd make sense to switch to

'*': [package_name]
'lucid':
  pip:
    packages: [pip_package_name]

For a more compact and maintainable version.

@jorritsmit
Copy link
Contributor Author

i can do both, what do you prefer?

@tfoote
Copy link
Member

tfoote commented Jul 25, 2018

Using the * syntax for the current and expected future versions would be great. Listing the older versions explicitly as blank.

@mikaelarguedas
Copy link
Member

@jorritsmit gentle 🛎️

mikaelarguedas
mikaelarguedas reviewed Aug 6, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good to me except the wildcard use for the python-requests rules

rosdep/python.yaml Outdated
zesty: [python-requests]
zesty_python3: [python3-requests]
'*': [python-requests]
'*_python3': [python3-requests]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the '*' syntax cannot be used with the _python3 suffix at the moment. so for this partivular key we need to either keep listing all of them explicitely or at lease keep all the <OS>_python3 entries

mikaelarguedas
mikaelarguedas approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jorritsmit for iterating!

I'll leave it up to @tfoote to provide 2nd review and merge

@mikaelarguedas mikaelarguedas dismissed tfoote’s stale review August 8, 2018 21:16

changes happened, new review required

@mikaelarguedas mikaelarguedas mentioned this pull request Aug 8, 2018
Merged
@mikaelarguedas
Copy link
Member

Rebased and resolved conflicts now that #18767 has been merged

@mikaelarguedas mikaelarguedas merged commit 11ba5b9 into ros:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorritsmit @tfoote @mikaelarguedas