-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rosdep: Added ruby-dev as a separate key #18302
Conversation
For now it's a copy of key `ruby`, without the specializations for Ubuntu EOL distros. In the future we would like to split ruby dependencies in run-time and build-time. Furthermore some Orocos packages would require the `ruby-dev` key for compatibility with the AutoProj package set (https://github.com/rock-core/package_set) used by the Rock community. The `manifest.xml` file was originally supposed to be compatible to ROS/rosdep and AutoProj.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make sense to split this out if the dependencies are noteably different.
We will need to have a fully planned out migration since there are likely a lot of packages currently relying on the build and runtime dependencies provided together.
rosdep/ruby.yaml
Outdated
fedora: [ruby, ruby-devel, openssl-devel, rubygems] | ||
gentoo: [dev-lang/ruby] | ||
macports: [ruby] | ||
ubuntu: [ruby, ruby-dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is to be a future only dev version should we not include the full ruby dependency here?
I did not change the With
If I understand correctly you are asking to remove the full ruby dependency and only depend on |
Yes, this won't break anything in itself, but I'd like to have a general plan for how to make the future migration. If we don't plan it out we can back ourselves into a corner. I think in this case since artful and bionic are not yet defined and artful is going EOL this month. We could take the opportunity to switch that platform over. However, Bionic is closed to stretch so we'd likely want to switch it over too. However stretch is already defined and being used for both Lunar and Melodic. Luckily as we're strictly removing dependencies we could set the policy that on buster and newer Packages on stretch that depend on So I'd suggest that in conjunction with adding the currently proposed And for Debian explicitly call out This should allow all users to make the transition with the simple requirement that they make sure to use |
This is in coordination with ros#18302
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
For now it's a copy of key
ruby
, without the specializations for Ubuntu EOL distros.In the future we would like to split ruby dependencies in run-time and build-time.
Furthermore some Orocos packages (e.g. typelib, see also orocos-toolchain/typelib#109) would require the
ruby-dev
key for compatibility with the AutoProj package set used by the Rock community. Themanifest.xml
file was originally supposed to be compatible to ROS/rosdep and AutoProj.