Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point to groovy-devel branch #15767

Merged
merged 2 commits into from
Aug 14, 2017

Conversation

mikaelarguedas
Copy link
Member

Up until lunar the master branch was used for all ros distributions.
Now that there is a lunar-devel branch I copied master on a groovy-devel branch to avoid confusion for users and woud like to remove the master branch.

Should I update all distribution files even for EOL rosdistros to reflect the new branch name ? or should I keep the master branch around and references to it for hydro and older distributions ?

@tfoote
Copy link
Member

tfoote commented Aug 14, 2017

It's a little bit of a pain for anyone with a source checkout but not the end of the world. However it should decrease future confusion. A branch named master that's not the tip would cause a lot of confusion, so I'd suggest it's better to switch.

@mikaelarguedas
Copy link
Member Author

@tfoote I added 48da0a1 to propagate the new-branch name everywhere, which makes travis unhappy. Should we merge it anyway to allow to delete the master branch ?

@dirk-thomas
Copy link
Member

Should we merge it anyway to allow to delete the master branch ?

Sure.

@tfoote
Copy link
Member

tfoote commented Aug 14, 2017

Yes, wei'll have to override the CI. it doesn't know that this is just a rename not a new release.

@mikaelarguedas mikaelarguedas merged commit 6ceb4d7 into ros:master Aug 14, 2017
@mikaelarguedas mikaelarguedas deleted the update_bond_core_branches branch August 14, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants