cleanup for count_packages script #15474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Jul 11, 2017
scripts/count_rosdistro_packages.py
Outdated
| @@ -14,6 +14,8 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from __future__ import print_function | |||
There was a problem hiding this comment.
This change seems to be unnecessary.
There was a problem hiding this comment.
We don't need to keep python2 compatibility for this. I was testing it with both. Removed.
There was a problem hiding this comment.
The change has nothing to do with Python 2 / 3 compatibility. The code should work fine with both versions without that line.
dirk-thomas
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for creating nice graphics of the history of releases. And will likely get added to the metrics reports.