Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heavy cleanup of the draw_square tutorial. #152

Merged
merged 2 commits into from
May 23, 2023
Merged

Heavy cleanup of the draw_square tutorial. #152

merged 2 commits into from
May 23, 2023

Conversation

clalancette
Copy link

In particular:

  1. Make it conform to the current ROS 2 style.
  2. Add in copyright information.
  3. Refactor the entire code into a class, which tidies it up quite a bit and removes a bunch of globals.
  4. Make sure to wait for the reset to complete before trying to move the turtle.

@clalancette
Heavy cleanup of the draw_square tutorial.
e08b932 
In particular:
1. Make it conform to the current ROS 2 style.
2. Add in copyright information.
3. Refactor the entire code into a class, which tidies it
   up quite a bit and removes a bunch of globals.
4. Make sure to wait for the reset to complete before trying
   to move the turtle.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette requested a review from ahcorde as a code owner May 22, 2023 21:57
@clalancette clalancette mentioned this pull request May 22, 2023
Closed
ahcorde
ahcorde requested changes May 23, 2023
View reviewed changes
Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to include ament_lint_auto ?

turtlesim/tutorials/draw_square.cpp Outdated Show resolved Hide resolved
turtlesim/tutorials/draw_square.cpp Outdated Show resolved Hide resolved
@clalancette
Copy link
Author

Does it make sense to include ament_lint_auto ?

It's a good question. I ended up not doing this because I would then have to change the style of all of the files in this package, and I wanted to concentrate on fixing draw_square for now. I think we should eventually clean this up and do that, but as a separate PR.

That said, I'll do the updates you suggest above.

@clalancette
Style cleanups from uncrustify.
2e574e3 
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit e4dade1 into rolling May 23, 2023
1 check passed
@ahcorde ahcorde deleted the clalancette/cleanup-draw-square branch May 23, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @ahcorde