Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added galactic turtle icon. #123

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

kscottz
Copy link

@kscottz kscottz commented May 21, 2021

Added the ROS 2 Galactic turtle icon.

@cottsay
Copy link
Member

cottsay commented May 21, 2021

I believe that the new path needs to be added to list of turtles right here:

QVector<QString> turtles;
turtles.append("box-turtle.png");
turtles.append("robot-turtle.png");
turtles.append("sea-turtle.png");
turtles.append("diamondback.png");
turtles.append("electric.png");
turtles.append("fuerte.png");
turtles.append("groovy.png");
turtles.append("hydro.svg");
turtles.append("indigo.svg");
turtles.append("jade.png");
turtles.append("kinetic.png");
turtles.append("lunar.png");
turtles.append("melodic.png");
turtles.append("noetic.png");

@kscottz
Copy link
Author

kscottz commented May 21, 2021

Those are all ROS 1 but I went and modified the ROS 2 distros.

@cottsay
Copy link
Member

cottsay commented May 21, 2021

Those are all ROS 1

Sorry about that - I had referenced the noetic-devel branch instead of galactic-devel.

I went and modified the ROS 2 distros

Perfect, looks good.

@cottsay
Copy link
Member

cottsay commented May 21, 2021

I pulled this change locally and it looks good!
TurtleSim

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cottsay cottsay merged commit 716a27f into ros:galactic-devel May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants