Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore key up events in teleop_turtle_key on Windows #118

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

hidmic
Copy link

@hidmic hidmic commented Apr 15, 2021

Precisely what the title says. Without this, goals were sent twice, resulting in:

C:\opt\ros>ros2 run turtlesim turtlesim_node
[INFO] [1618522185.883591800] [turtlesim]: Starting turtlesim with node name /turtlesim
[INFO] [1618522185.899227100] [turtlesim]: Spawning turtle [turtle1] at x=[5.544445], y=[5.544445], theta=[0.000000]
[INFO] [1618522191.815428400] [turtlesim]: Rotation goal completed successfully
[INFO] [1618522191.878537900] [turtlesim]: Rotation goal completed successfully
[WARN] [1618522207.286362400] [turtlesim]: Rotation goal received before a previous goal finished. Aborting previous goal
[INFO] [1618522209.606408200] [turtlesim]: Rotation goal completed successfully

Copy link

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.
I also think that getting the "previous goal canceled" message wasn't pretty confusing.

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try this locally, but it looks good to me!

@hidmic
Copy link
Author

hidmic commented Apr 16, 2021

I didn't try this locally

I did.

Running Windows CI for completeness: Build Status

@hidmic
Copy link
Author

hidmic commented Apr 16, 2021

Alright, going in.

@hidmic hidmic merged commit be98147 into galactic-devel Apr 16, 2021
@hidmic hidmic deleted the hidmic/fix-teleop-turtle-key branch April 16, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants