Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port actionlib_tools to Python 3 #169

Merged
merged 4 commits into from
Aug 21, 2020
Merged

Port actionlib_tools to Python 3 #169

merged 4 commits into from
Aug 21, 2020

Conversation

mikaelarguedas
Copy link
Member

Based on #168 and ros/rosdistro#25920

Should fix #153 and #167

@mikaelarguedas mikaelarguedas mentioned this pull request Aug 16, 2020
Closed
mjcarroll
mjcarroll approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment on shebang consistency

actionlib_tools/scripts/axclient.py Outdated Show resolved Hide resolved
@mikaelarguedas mikaelarguedas mentioned this pull request Aug 21, 2020
Merged
@mjcarroll mjcarroll merged commit 2de1868 into ros:noetic-devel Aug 21, 2020
@Tobias-Fischer Tobias-Fischer mentioned this pull request Sep 21, 2020
Open
@mikaelarguedas mikaelarguedas deleted the port_actionlib_tools_to_python3 branch October 14, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@reinzor reinzor reinzor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noetic Python 2 dependency on wxtools
3 participants
@mikaelarguedas @mjcarroll @reinzor