Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CMake version to avoid CMP0048 warning #459

Merged
merged 1 commit into from
May 15, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 26, 2020

This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

Signed-off-by: ahcorde [email protected]

@dirk-thomas
Copy link
Contributor

This will need a branch for pre-Kinetic versions in order to not break those.

@ahcorde ahcorde changed the title ]Bump CMake version to avoid CMP0048 warning Bump CMake version to avoid CMP0048 warning Mar 26, 2020
@sloretz
Copy link
Contributor

sloretz commented May 15, 2020

This will need a branch for pre-Kinetic versions in order to not break those.

Done ros/rosdistro#24919

@sloretz sloretz merged commit a11901e into ros-visualization:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants