Deprecated h headers #294
Merged
Deprecated h headers #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
requested changes
Jul 3, 2024
Comment on lines
+36
to
+38
| // *INDENT-OFF* (prevent uncrustify from adding indention below) | ||
| #warning Including header <qt_gui_cpp/composite_plugin_provider.h> is deprecated, \ | ||
| include <qt_gui_cpp/composite_plugin_provider.hpp> instead. |
There was a problem hiding this comment.
If we have to do INDENT-OFF, we also need to remember to turn it back on. This probably doesn't matter much in these header files, but we should just be consistent:
Suggested change
| // *INDENT-OFF* (prevent uncrustify from adding indention below) | |
| #warning Including header <qt_gui_cpp/composite_plugin_provider.h> is deprecated, \ | |
| include <qt_gui_cpp/composite_plugin_provider.hpp> instead. | |
| // *INDENT-OFF* (prevent uncrustify from adding indention below) | |
| #warning Including header <qt_gui_cpp/composite_plugin_provider.h> is deprecated, \ | |
| include <qt_gui_cpp/composite_plugin_provider.hpp> instead. | |
| // *INDENT-ON* |
(same goes for all other .h header files below)
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
requested changes
Jul 8, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
clalancette
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.