Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
qt_gui_cpp_sip
when running macOS.Partial fix for ros-visualization/python_qt_binding#103. See also ros-visualization/python_qt_binding#118 which is a pre-requisite for this change.
Qt bindings for macOS are available using PySide2. The brew formula for
pyside@2
is keg only, to build and run using PySide2 set the environment variables:The changes to
qt_gui_cpp_shiboken
address include path resolution issues that caused the build to fail. The modification for theqt_gui_cpp_INCLUDE_PATH
is not very satisfactory. Using the component propertiesQt5Core_INCLUDE_DIRS
etc. which would be preferable does not seem to work.