-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPEG only supports 8 bits images #73
JPEG only supports 8 bits images #73
Conversation
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
To make the Gpr and Rpr checkers pass, #72 is needed. |
Instead of failing on publisher side, what do you think about simply converting all image types to |
@mallanmba's suggestion seems reasonable to me. |
I'm pretty sure I tried that (publishing a rgb16 image that was converted to bgr8), and it was also not working. |
…le race Signed-off-by: Ivan Santiago Paunovic <[email protected]>
* Handle the 'rclcpp::exceptions::ParameterAlreadyDeclared' exception. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
…argument Signed-off-by: Ivan Santiago Paunovic <[email protected]>
2f03df9
to
a273bf9
Compare
Depends on:
Now mono16 images are being published as mono8, simular to what was suggested here. This PR is also:
There are still things that I find weird, but I didn't want to modify:
|
Fpr and Gpr are expected to fail, as this branch isn't intended to be compatible with them (there's a galactic and a foxy branch). |
@jacobperron could you take another look? |
Pinging @mjcarroll as a maintainer. |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@ros-pull-request-builder retest this please |
The Fpr and Gpr failures are expected, because this is overriding methods added after ros-perception/image_common#195 and ros-perception/image_common#186. The Rpr checker was passing before, the error in the last run seems to be random. This PR seems to overlap with #78. |
@ros-pull-request-builder retest this please |
@mjcarroll Should we modify the release repository to use the Same in rosdistro https://github.com/ros/rosdistro/blob/ec8dd166b57d3667c9353c002691bae9ddc7fa6e/galactic/distribution.yaml#L1053. I have checked both |
Yes, I think so, I can take care of it. |
|
@ros-pull-request-builder retest this please |
JPEG only supports 8bit images.
If you currently use a 16 bit image with jpeg compressed image transport and use rqt_image_view to try to plot it you get the following errors:
when publishing MONO16
when publishing RGB16
and the publisher side doesn't fail.
After this patch, the publisher side fails showing the following message: