Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete views instructions #485

Merged
merged 5 commits into from
Nov 14, 2017
Merged

Conversation

mikaelarguedas
Copy link
Contributor

This alse fixes the style so that the new section can be displayed correctly

* ``Lrel_`` which matches the Lunar release related management jobs.
* ``Ldev_`` which matches the Lunar devel jobs as well as the management related jobs.
* ``Ldoc_`` which matches the Lunar doc jobs as well as the management related jobs.
* ``Lpr_`` which matches the Lunar PR jobs as well as the management related jobs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid unrelated whitespace changes like this. All other files use a space to indent the bullets.

Copy link
Contributor Author

@mikaelarguedas mikaelarguedas Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change the bullet list is displayed as commented out / quoted. That doesn't seem to be what we want here. I can submit it as a separate PR if you prefer

Deleting all views related to a ROS distribution
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If you deleted all the jobs of a given ROS distribution, noe all the views associated with them are empty.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noe?

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If you deleted all the jobs of a given ROS distribution, noe all the views associated with them are empty.
You can delete them manually by going to specific view and click the "Delete View" button on the left sidebar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to specific view

Missing "the"?


If you deleted all the jobs of a given ROS distribution, noe all the views associated with them are empty.
You can delete them manually by going to specific view and click the "Delete View" button on the left sidebar.
Or programmatically, using the same prefixes as the ones use to delete the jobs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the ones use to delete

"used"?

@mikaelarguedas
Copy link
Contributor Author

thanks for homogenizing the bullet lists

@mikaelarguedas mikaelarguedas merged commit fd7f2d1 into master Nov 14, 2017
@mikaelarguedas mikaelarguedas deleted the add_delete_views_instructions branch November 14, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants